Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Migrator): add step option #1013

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

MaximeMRF
Copy link
Contributor

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

As discuss in the pr #940 here is the step option for the migration rollback.

At the moment if you use step option with batch option too, the batch option will not work and only the effect of the step option will count.
Another behavior is when you use a negative number it will rollback all migrations.

What's your opinion about theses behaviors ?

@thetutlage
Copy link
Member

@MaximeMRF Can you please document it as well?

@thetutlage thetutlage merged commit 196c97c into adonisjs:develop Mar 15, 2024
16 checks passed
@MaximeMRF
Copy link
Contributor Author

Yes i will do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants