Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: omit double quotes from connection name #983

Merged
merged 2 commits into from
Mar 8, 2024
Merged

fix: omit double quotes from connection name #983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bbe54c
fix: omit double quotes from connection name
pokedpeter Jan 16, 2024
b56eb4a
Merge branch 'develop' into fix-connection-param
pokedpeter Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions commands/migration/fresh.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export default class Refresh extends BaseCommand {
}

if (this.connection) {
args.push(`--connection="${this.connection}"`)
args.push(`--connection=${this.connection}`)
}

if (this.disableLocks) {
Expand Down Expand Up @@ -117,7 +117,7 @@ export default class Refresh extends BaseCommand {
private async runDbSeed() {
const args: string[] = []
if (this.connection) {
args.push(`--connection="${this.connection}"`)
args.push(`--connection=${this.connection}`)
}

const dbSeed = await this.kernel.exec('db:seed', args)
Expand Down
4 changes: 2 additions & 2 deletions commands/migration/refresh.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export default class Refresh extends BaseCommand {
}

if (this.connection) {
args.push(`--connection="${this.connection}"`)
args.push(`--connection=${this.connection}`)
}

if (this.dryRun) {
Expand Down Expand Up @@ -99,7 +99,7 @@ export default class Refresh extends BaseCommand {
private async runDbSeed() {
const args: string[] = []
if (this.connection) {
args.push(`--connection="${this.connection}"`)
args.push(`--connection=${this.connection}`)
}

const dbSeed = await this.kernel.exec('db:seed', args)
Expand Down
2 changes: 1 addition & 1 deletion commands/migration/reset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export default class Reset extends BaseCommand {
}

if (this.connection) {
args.push(`--connection="${this.connection}"`)
args.push(`--connection=${this.connection}`)
}

if (this.dryRun) {
Expand Down
Loading