Skip to content

Cookie leakage between different users in fastapi-proxy-lib

High severity GitHub Reviewed Published Dec 1, 2023 in WSH032/fastapi-proxy-lib • Updated Dec 1, 2023

Package

pip fastapi-proxy-lib (pip)

Affected versions

< 0.1.0

Patched versions

0.1.0

Description

Impact

In the implementation of version 0.0.1, requests from different user clients are processed using a shared httpx.AsyncClient.

However, one oversight is that the httpx.AsyncClient will persistently store cookies based on the set-cookie response header sent by the target server and share these cookies across different user requests.

This results in a cookie leakage issue among all user clients sharing the same httpx.AsyncClient.

Patches

It's fixed in 0.1.0

Workarounds

If you insist 0.0.1:

  • Do not use ForwardHttpProxy at all.
  • Do not use ReverseHttpProxy or ReverseWebSocketProxy for any servers that may potentially send a set-cookie response.

However, it's best to upgrade to the latest version.

References

fixed in #10

References

@WSH032 WSH032 published to WSH032/fastapi-proxy-lib Dec 1, 2023
Published to the GitHub Advisory Database Dec 1, 2023
Reviewed Dec 1, 2023
Last updated Dec 1, 2023

Severity

High

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v3 base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
High
Integrity
None
Availability
None

CVSS v3 base metrics

Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:N

Weaknesses

No CWEs

CVE ID

No known CVE

GHSA ID

GHSA-7vwr-g6pm-9hc8

Source code

Loading Checking history
See something to contribute? Suggest improvements for this vulnerability.