Update:devcontainer dev.js default to not skip binaries check, fail g…

…racefully if required binary env variables are not set when skipping
advplyr · Aug 1, 2024 · 4a5345d · 4a5345d
1 parent 1e6dd0e
commit 4a5345d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.devcontainer/dev.js b/.devcontainer/dev.js
@@ -6,5 +6,5 @@ module.exports.config = {
   MetadataPath: Path.resolve('metadata'),
   FFmpegPath: '/usr/bin/ffmpeg',
   FFProbePath: '/usr/bin/ffprobe',
-  SkipBinariesCheck: true
-}
+  SkipBinariesCheck: false
+}
diff --git a/server/managers/BinaryManager.js b/server/managers/BinaryManager.js
@@ -275,6 +275,12 @@ class BinaryManager {
   async init() {
     // Optional skip binaries check
     if (process.env.SKIP_BINARIES_CHECK === '1') {
+      for (const binary of this.requiredBinaries) {
+        if (!process.env[binary.envVariable]) {
+          await Logger.fatal(`[BinaryManager] Environment variable ${binary.envVariable} must be set`)
+          process.exit(1)
+        }
+      }
       Logger.info('[BinaryManager] Skipping check for binaries')
       return
     }