Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ellipsoids #26

Merged
merged 10 commits into from
Mar 22, 2024
Merged

Ellipsoids #26

merged 10 commits into from
Mar 22, 2024

Conversation

aelanman
Copy link
Owner

Switch to using ellipsoid models in defining selenodetic coordinates. Ellipsoids are called "selenoids" in analogy with "geoids".

Updates some tests accordingly. This is needed for corresponding changes in pyuvdata.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 96.22642% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.48%. Comparing base (4be9e04) to head (172a77a).
Report is 2 commits behind head on main.

Files Patch % Lines
lunarsky/moon.py 95.74% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   86.64%   86.48%   -0.17%     
==========================================
  Files           7        8       +1     
  Lines         584      614      +30     
==========================================
+ Hits          506      531      +25     
- Misses         78       83       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bhazelton bhazelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you so much! The only thing I wondered is if you want to add testing against python 3.12.

.github/workflows/testsuite.yaml Outdated Show resolved Hide resolved
@aelanman aelanman merged commit 9140a6e into main Mar 22, 2024
12 checks passed
@aelanman aelanman deleted the ellipsoids branch March 22, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants