-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ellipsoids #26
Ellipsoids #26
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
- Coverage 86.64% 86.48% -0.17%
==========================================
Files 7 8 +1
Lines 584 614 +30
==========================================
+ Hits 506 531 +25
- Misses 78 83 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you so much! The only thing I wondered is if you want to add testing against python 3.12.
Switch to using ellipsoid models in defining selenodetic coordinates. Ellipsoids are called "selenoids" in analogy with "geoids".
Updates some tests accordingly. This is needed for corresponding changes in pyuvdata.