Fix handling of constant inputs to SubsumingElemwise
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
force-pushed
the
fix-subsuming-constants
branch
3 times, most recently
from
674dc12 to
37a4cf3
Compare
Codecov ReportBase: 98.28% // Head: 98.29% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
=======================================
Coverage 98.28% 98.29%
=======================================
Files 10 10
Lines 698 702 +4
Branches 62 65 +3
=======================================
+ Hits 686 690 +4
Misses 5 5
Partials 7 7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
brandonwillard
force-pushed
the
fix-subsuming-constants
branch
from
37a4cf3 to
55632f1
Compare
rlouf
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the error seen in #90.
The underlying issue is that
SubsumingElemwiseextendsOpFromGraphand the latter does not accept constant inputs (e.g. anOpFromGraphrepresenting1 / xshould only takexas an input, and not also1). This PR removes constant inputs when theOpFromGraphis constructed and also strips them from calls toSubsumingElemwise.make_node. The assumption is that the inputs provided in both cases (i.e. when theOpis constructed and when the constructedOpis used to create a node) refer to the same constants, which they absolutely should in this scenario.