Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: connect to wallet without node (wip) #1398

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented Jan 31, 2022

by request of @zxq9

Discussion points:

  • Seems that the networkId only need to ensure that aepp and wallet are connected to the same network, so in this case, it can be omitted on the aepp side.
  • Can we agree on placeholders in an encoded transaction that the wallet should replace with actual values? Instead of doing high-level API between aepp and wallet

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #1398 (c684ee9) into develop (07bc105) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1398   +/-   ##
========================================
  Coverage    87.86%   87.86%           
========================================
  Files           54       54           
  Lines         3089     3089           
  Branches        40       40           
========================================
  Hits          2714     2714           
  Misses         354      354           
  Partials        21       21           
Impacted Files Coverage Δ
...rc/utils/aepp-wallet-communication/rpc/aepp-rpc.js 94.89% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07bc105...c684ee9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant