Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract non-transactions into separate entry builder #1962

Merged
merged 1 commit into from
May 29, 2024

Conversation

davidyuk
Copy link
Member

This PR is supported by the Æternity Foundation

@davidyuk davidyuk added this to the v14.0.0 milestone Mar 13, 2024
@davidyuk davidyuk changed the title Extract non-transaction into separate entry builder Extract non-transactions into separate entry builder Mar 13, 2024
@davidyuk davidyuk force-pushed the feature/extract-entry-packing branch from a551a1a to 87278c2 Compare March 13, 2024 07:30
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 97.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.44%. Comparing base (9653784) to head (d5fde18).

Files Patch % Lines
src/tx/builder/entry/schema.ts 96.66% 0 Missing and 1 partial ⚠️
src/tx/builder/field-types/wrapped.ts 50.00% 1 Missing ⚠️
src/tx/builder/schema.ts 96.77% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1962      +/-   ##
===========================================
+ Coverage    80.25%   80.44%   +0.19%     
===========================================
  Files          104      107       +3     
  Lines         3570     3611      +41     
  Branches       772      773       +1     
===========================================
+ Hits          2865     2905      +40     
+ Misses         384      382       -2     
- Partials       321      324       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidyuk davidyuk force-pushed the feature/extract-entry-packing branch from 87278c2 to eaa94a6 Compare May 29, 2024 06:16
BREAKING CHANGE: `buildTx`/`unpackTx` works only with transactions
If you need to work with node's entry use `packEntry`/`unpackEntry`.

BREAKING CHANGE: `Tag` include only transactions
Node entries tags moved to `EntryTag`.

BREAKING CHANGE: `buildTx` doesn't accept `prefix` anymore
Use `decode`/`encode` to convert payload to desired format.
@davidyuk davidyuk force-pushed the feature/extract-entry-packing branch from eaa94a6 to d5fde18 Compare May 29, 2024 06:28
@davidyuk davidyuk merged commit 9848eeb into develop May 29, 2024
5 checks passed
@davidyuk davidyuk deleted the feature/extract-entry-packing branch May 29, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant