fix(aepp): don't require subscription to request addresses #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidyuk
added this to the Simplify, improve, and refactor aepp-wallet connection milestone
davidyuk
force-pushed
the
feature/aepp-address
branch
from
4b3cc7e to
fe7f0f9
Compare
davidyuk
force-pushed
the
feature/aepp-address
branch
from
fe7f0f9 to
2b247ff
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1981 +/- ##
===========================================
+ Coverage 80.33% 80.36% +0.02%
===========================================
Files 104 104
Lines 3570 3570
Branches 771 771
===========================================
+ Hits 2868 2869 +1
+ Misses 384 381 -3
- Partials 318 320 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it is not checked/required on the other side.
This PR is supported by the Æternity Foundation