Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AccountMetamask #2023

Merged
merged 10 commits into from
Oct 5, 2024
Merged

Add AccountMetamask #2023

merged 10 commits into from
Oct 5, 2024

Conversation

@davidyuk davidyuk added this to the v14.0.0 milestone Oct 2, 2024
@davidyuk davidyuk changed the title Add AccountMetaMask Add AccountMetamask Oct 2, 2024
@davidyuk davidyuk force-pushed the snap branch 8 times, most recently from 597fa21 to f05498b Compare October 2, 2024 10:29
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 82.62%. Comparing base (c664255) to head (0831f08).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
src/account/MetamaskFactory.ts 73.33% 11 Missing and 1 partial ⚠️
src/account/Metamask.ts 63.63% 8 Missing ⚠️
src/utils/errors.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2023      +/-   ##
===========================================
- Coverage    82.92%   82.62%   -0.30%     
===========================================
  Files          109      111       +2     
  Lines         3625     3695      +70     
  Branches       751      767      +16     
===========================================
+ Hits          3006     3053      +47     
- Misses         524      546      +22     
- Partials        95       96       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidyuk davidyuk merged commit 7dfb62f into develop Oct 5, 2024
3 of 5 checks passed
@davidyuk davidyuk deleted the snap branch October 5, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support metamask snap?
1 participant