Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: UI fixes #934

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

fix: UI fixes #934

wants to merge 19 commits into from

Conversation

janmichek
Copy link
Collaborator

@janmichek janmichek commented Sep 17, 2024 •
edited
Loading

Description

fixes #910
fixes #854

  • improved github output
  • replace --- for 'N/A'
  • remove duplicate ae logo
  • fetchTokenHoldersCount optimization
  • floor line chart to minimum value of 0 so -1 is not visible on Y axis
  • header STATE CHANNELS -> LATEST ACTIVE STATE CHANNELS
  • make Tabs semi transparent
  • highlight table row on hover

Demo

Checklist:

  • Measure performance after removing booster

@github-actions GitHub Actions
Copy link

🧪️ Preview Links 🔎️

Mainnet: https://pr-934-aescan.stg.service.aepps.com
Testnet: https://pr-934-aescan-testnet.stg.service.aepps.com

@janmichek janmichek added this to the Q4 2024 milestone Oct 23, 2024
@janmichek janmichek requested review from Liubov-crypto and removed request for Liubov-crypto November 4, 2024 08:37
@Liubov-crypto
Copy link
Collaborator

Small bugs:

  1. question mark is shifted:
2024-11-04.4.10.02.mov
  1. Line on chart is cropped:
2024-11-04.4.12.33.mov
  1. Double AE labels and data is shifted:
2024-11-04.4.23.01.mov

ae

Liubov-crypto
Liubov-crypto suggested changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janmichek please check my comments above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liubov-crypto Liubov-crypto Liubov-crypto requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Q4 2024
Development

Successfully merging this pull request may close these issues.

Fix names blank states Remove 0 bri reward
2 participants
@janmichek @Liubov-crypto