Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending readme #101

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Extending readme #101

merged 1 commit into from
Oct 18, 2024

Conversation

flborn
Copy link

@flborn flborn commented Oct 16, 2024

Extended readme with REST API description

Summary by CodeRabbit

  • New Features

    • Introduced a REST API for managing categories in KiCad, allowing programmatic interactions.
    • Added endpoints for retrieving, adding, updating, and deleting categories.
  • Documentation

    • Updated the README.md to include detailed instructions on using the new API.
    • Restructured sections to enhance clarity and usability for developers.

Copy link

coderabbitai bot commented Oct 16, 2024

Walkthrough

The changes in this pull request primarily involve updates to the README.md file, introducing a new section that describes the use of a REST API for managing categories in KiCad. This section replaces the previous instructions for adding categories through the admin backend and details various API endpoints for retrieving, adding, updating, and deleting categories. Additionally, the documentation has been restructured to reflect these changes, emphasizing API-driven interactions and updating related content on footprint parameter mapping.

Changes

File Change Summary
README.md Added a new section on using a REST API for category management, replacing admin backend instructions. Updated and restructured content on "Default Settings for Categories" and footprint parameter mapping.
New API endpoints: GET /plugin/kicad-library-plugin/api/category/, GET /plugin/kicad-library-plugin/api/category/<id>/, POST /plugin/kicad-library-plugin/api/category/, PATCH /plugin/kicad-library-plugin/api/category/<id>/, DELETE /plugin/kicad-library-plugin/api/category/<id>/.

Possibly related PRs

  • Add REST API to manage selected KiCad categories #100: The main PR's changes to the README.md regarding the REST API for category management directly relate to the implementation of the REST API in the retrieved PR, which adds endpoints for managing categories in the KiCadLibraryPlugin.py, serializers.py, and viewsets.py files.

Poem

In the land of KiCad, where circuits do play,
A REST API blooms, brightening the way.
Categories now dance with a click and a call,
No more admin fuss, just API for all!
With endpoints aplenty, our joy's here to stay,
Hopping through code, we celebrate today! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (3)
README.md (3)

59-194: Excellent addition of REST API documentation.

The new section on adding categories to KiCad via REST API is a valuable addition to the documentation. It provides clear and detailed information about the available endpoints and their usage. Here are a few minor suggestions for improvement:

  1. Consider adding language specifiers to the code blocks for better syntax highlighting. For example, use json instead of just .
  2. In line 175, there's a small formatting issue. Change "e. g.:" to "e.g.:" (remove the space before "g").

Overall, this section greatly enhances the usability of the plugin for developers working with the API.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~175-~175: There should be no space here.
Context: ... contain the values you want to change, e. g.: ``` { "default_symbol": "Device:C...

(EG_SPACE)

🪛 Markdownlint

69-69: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


126-126: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


157-157: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


176-176: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


195-200: Minor wording improvement suggested.

The "Default Settings for Categories" section provides clear information about the purpose and benefits of default values. To improve clarity, consider revising the following sentence:

"This feature is particularly useful when dealing with components such as resistors or capacitors, as they often share the same symbols, reducing the need for repetitive data entry."

You could simplify it to:

"This feature is particularly useful for components like resistors or capacitors that often share the same symbols, reducing repetitive data entry."

This change removes the redundant use of "specific details" and makes the sentence more concise.

🧰 Tools
🪛 LanguageTool

[style] ~197-~197: This phrase is redundant. Consider writing “details”.
Context: ...efault values when the child part lacks specific details regarding the KiCad symbol, footprint, ...

(SPECIFIC_DETAILS)


Line range hint 265-280: Great addition: Stock Information Display in KiCad.

The new section on displaying stock information in KiCad is a valuable addition to the documentation. It provides clear instructions on how to activate and customize the feature. The images effectively illustrate the settings and the result in KiCad.

Minor suggestion:
Consider formatting the note at the end as a blockquote for better visibility. You can do this by adding a > at the beginning of the line:

> **Please Note:** The stock information is not transferred into the schematic. It is only visible inside the symbol chooser!

This change will make the note stand out more in the rendered markdown.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~175-~175: There should be no space here.
Context: ... contain the values you want to change, e. g.: ``` { "default_symbol": "Device:C...

(EG_SPACE)


[style] ~197-~197: This phrase is redundant. Consider writing “details”.
Context: ...efault values when the child part lacks specific details regarding the KiCad symbol, footprint, ...

(SPECIFIC_DETAILS)

🪛 Markdownlint

69-69: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


126-126: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


157-157: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


176-176: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 3ebe086 and a347d7d.

📒 Files selected for processing (1)
  • README.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md

[uncategorized] ~175-~175: There should be no space here.
Context: ... contain the values you want to change, e. g.: ``` { "default_symbol": "Device:C...

(EG_SPACE)


[style] ~197-~197: This phrase is redundant. Consider writing “details”.
Context: ...efault values when the child part lacks specific details regarding the KiCad symbol, footprint, ...

(SPECIFIC_DETAILS)

🪛 Markdownlint
README.md

69-69: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


126-126: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


157-157: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


176-176: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

🔇 Additional comments (2)
README.md (2)

Line range hint 201-211: LGTM: Clear explanation of Footprint Parameter Mapping.

The updated section on "Utilizing Footprint Parameter Mapping" provides clear and concise information about how to use this feature with the KiCad category. The addition of images greatly enhances the explanation and makes it easier for users to understand the process. This update aligns well with the new API-driven approach introduced in the earlier sections.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~175-~175: There should be no space here.
Context: ... contain the values you want to change, e. g.: ``` { "default_symbol": "Device:C...

(EG_SPACE)


[style] ~197-~197: This phrase is redundant. Consider writing “details”.
Context: ...efault values when the child part lacks specific details regarding the KiCad symbol, footprint, ...

(SPECIFIC_DETAILS)

🪛 Markdownlint

69-69: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


126-126: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


157-157: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


176-176: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


Line range hint 1-326: Excellent improvements to the README documentation.

The updated README provides a comprehensive guide to the InvenTree KiCad HTTP Library Plugin. The additions and restructuring have significantly enhanced the document's value to users. Here are the key improvements:

  1. The new REST API section provides clear instructions for programmatic interaction with the plugin.
  2. The document flow has been improved, with a logical progression from installation to advanced usage.
  3. The liberal use of images throughout the document greatly aids in understanding the plugin's features and configuration.
  4. The content caters to users with varying levels of expertise, from basic setup to advanced API usage.

These changes will greatly assist users in understanding and utilizing the plugin effectively. Great job on improving the documentation!

🧰 Tools
🪛 LanguageTool

[uncategorized] ~175-~175: There should be no space here.
Context: ... contain the values you want to change, e. g.: ``` { "default_symbol": "Device:C...

(EG_SPACE)


[style] ~197-~197: This phrase is redundant. Consider writing “details”.
Context: ...efault values when the child part lacks specific details regarding the KiCad symbol, footprint, ...

(SPECIFIC_DETAILS)

🪛 Markdownlint

69-69: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


126-126: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


157-157: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


176-176: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

@afkiwers afkiwers merged commit c512f1e into afkiwers:main Oct 18, 2024
1 check passed
@afkiwers
Copy link
Owner

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants