Possible Bugfix in Tree::remove(...) #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ared_ptr<TreeNode> otherNode): Use while-loop with iterators instead of for-each-loop and check if thisNode->getChildren() has changed.
|
The idea of this method is unclear to me. It's used in the wpMethod of the FSM and DFSM class to remove the state cover from the transition cover. This shouldn't have any effect. So maybe we should rethink the whole method before merging a fix to the iterator problem. |
|
Sounds like a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Tree::remove(const shared_ptr thisNode, const shared_ptr otherNode) the thisNode->getChildren() list can change if children are deleted and removed.
In this case the iterator seems to get invalidated.
The new version could be one possible solution.