picamera-libs: removed unused libraries from python3-picamera #1292
Conversation
There was a problem hiding this comment.
This looks good. Could you tweak your commit subject to state the recipe name? Checkout https://meta-raspberrypi.readthedocs.io/en/latest/contributing.html for more info.
Does py3-camera work with mesa provided GL libraries ? |
|
The concept behind this is that the module does not use GL libs at all. I looked into the code and could only find libmmal.so and libbcm_host.so. GL does not seem to be a dependency. |
carlonluca
changed the title
OK, in that case, we should not install those either. If python pieces are abstacted enough that it does not demand MMAL |
|
Not sure if I'm understanding correctly what you are saying @kraj. libmmal and libbcm_host appear to be needed, so those, and their deps, should not be removed: https://github.com/waveform80/picamera/blob/master/picamera/mmal.py#L49 I'm not a picamera dev though. |
|
@kraj I think this specific removal makes sense. @carlonluca, have you managed to ask upstream why they include the GL libraries? |
|
I'm sorry, the situation is not completely clear to me. Can you provide more details? By "upstream" here, do you mean the authors of that python library (I guess this is the official repo: https://github.com/waveform80/picamera)? Where did they include the GL libraries? |
|
Scratch that last comment of mine. This is from the rpi firmware repo. |
Apparently the recipe for python3 picamera is installing some libraries from /opt/vc/lib that are not necessary to the picamera module. The gles2 library, in particular, overwrites a symlink to another version of the gles2 library. The result is that two different gles2 libs are placed in /usr/lib. This commit removes a few unneeded libraries, leaving libmmal and its dependencies, that are instead required. Signed-off-by: Luca Carlon <[email protected]>
|
@kraj, I see you had a comment on this. Thumbs up on the current patch? |
Apparently the recipe for python3 picamera is installing some libraries from /opt/vc/lib that are not necessary to the picamera module. The gles2 library, in particular, overwrites a symlink to another version of the gles2 library. The result is that two different gles2 libs are placed in /usr/lib.
This commit removes a few unneeded libraries, leaving libmmal and its dependencies, that are instead required.