Merge pull request #16 from agorapulse/fix/made-facebook-app-id-optional

Made Facebook App ID optional
agorapulse · Apr 17, 2024 · e59d58e · e59d58e
2 parents c98a49d + 8b8ff67
commit e59d58e
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 13 deletions.
diff --git a/...n/java/com/agorapulse/micronaut/facebooksdk/AbstractFacebookApplicationConfiguration.java b/...n/java/com/agorapulse/micronaut/facebooksdk/AbstractFacebookApplicationConfiguration.java
@@ -21,7 +21,6 @@
 
 import jakarta.validation.constraints.Min;
 import jakarta.validation.constraints.NotBlank;
-import jakarta.validation.constraints.NotNull;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -31,7 +30,7 @@ public abstract class AbstractFacebookApplicationConfiguration {
     @NotBlank
     private String secret;
 
-    @NotNull @Min(1)
+    @Min(1)
     private Long id;
 
     private String version = Version.LATEST.getUrlElement();

diff --git a/...t/groovy/com/agorapulse/micronaut/facebooksdk/FacebookApplicationConfigurationSpec.groovy b/...t/groovy/com/agorapulse/micronaut/facebooksdk/FacebookApplicationConfigurationSpec.groovy
@@ -28,23 +28,33 @@ import spock.lang.Specification
 @CompileDynamic
 class FacebookApplicationConfigurationSpec extends Specification {
 
-    FacebookApplication application
-
     @AutoCleanup ApplicationContext context
 
-    void setup() {
-        context = ApplicationContext.builder(
-            'facebook.sdk.app.api-version': 'v16.0',
-            'facebook.sdk.app.id': '1234567890',
-            'facebook.sdk.app.secret': 'secret'
-        ).build()
-        context.start()
+    void 'application version is converted'() {
+        given:
+            context = ApplicationContext.builder(
+                    'facebook.sdk.app.api-version': 'v16.0',
+                    'facebook.sdk.app.id': '1234567890',
+                    'facebook.sdk.app.secret': 'secret'
+            ).build()
+            context.start()
 
-        application = context.getBean(FacebookApplication)
+            FacebookApplication application = context.getBean(FacebookApplication)
+            FacebookClient client = application.createClient()
+        expect:
+            client instanceof DefaultFacebookClient
+            client.apiVersion == Version.VERSION_16_0
     }
 
-    void 'application version is converted'() {
+    void 'app id is optional'() {
         given:
+            context = ApplicationContext.builder(
+                    'facebook.sdk.app.api-version': 'v16.0',
+                    'facebook.sdk.app.secret': 'secret'
+            ).build()
+            context.start()
+
+            FacebookApplication application = context.getBean(FacebookApplication)
             FacebookClient client = application.createClient()
         expect:
             client instanceof DefaultFacebookClient