Modernize layer selector #259
Conversation
steveoh
commented
Jul 26, 2024
•
steveoh
commented
- make it accessible
There was a problem hiding this comment.
Do you want to clean up the old JSX + CSS component?
The SVG doesn't look right on my non-HD screen:
I think that it would be a bummer to make our users click an additional time. Could you keep the hover for desktop and only require a tap for mobile? Or is hovering not accessible?
The checkbox icon looks a little weird to me compared with the react aria default:
| ); | ||
| }; | ||
|
|
||
| export function LayerSelector<T extends object>({ children, ...props }) { |
There was a problem hiding this comment.
It would be nice to have some typescript to define the props.
|
|
||
| export default { | ||
| content: ['./packages/**/*.{js,jsx,ts,tsx}'], | ||
| darkMode: ['class'], | ||
| presets: [ugrcTheme], | ||
| plugins: [rac], |
There was a problem hiding this comment.
Could this be added to the preset? If not, then it needs to be documented.
|
Sure you could clean up the old one. I'm not sure about the hover. I don't really mind the click. That's pretty common in the other examples I've seen for map layers. We could certainly ship a different component like google for desktop. Yah the icon is different which is why it looks funny. It comes from a different icon library. I noticed the svg looks funny on safari. We could switch to the icons that adobe uses. They have the same icon for the layer selector and a whole lot more. |
steveoh
force-pushed
the
feat/layer-selector-tw
branch
from
ae73a3c
to
bad15dc
Compare
steveoh
force-pushed
the
feat/layer-selector-tw
branch
from
bad15dc
to
0f0d236
Compare
