Support swift 4.2 and add display callback #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support swift 4
add forked from
Update PickerDialog.swift
…allback swift4 and add display callback
update readme
add update for swift 5 and fixing some bugs
remove unused showing dialog
add some extra information version of swift
update readme
Update README.md
Update LICENSE
Update PickerDialog.swift
change default button height
Fixing UIColor Extension due error in XCode 14
Update sample usage, need add title argument due error in xcode
Update sample usage
Fixing UIColor Extension due error in XCode 14
add new viewcontroller parameter to show dialog
Fixing UIColor init Extensions
add new viewcontroller parameter to show dialog
Fixing UIColor init Extensions
Clean space intialization
Clean space intialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add some changes for support swift 4.2 and also I add display callback, sometime I need to know both value which is "display" and "value", but the current picker dialog only provide the "value" so I did some changes for the callback to showing "display" and "value", and also I add extension UIColor, becuase in your picker dialog not provide the extension it can cause this line error UIColor(hex: 0x333333)