Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cli #119

Merged
merged 5 commits into from
Sep 27, 2023
Merged

Update cli #119

merged 5 commits into from
Sep 27, 2023

Conversation

vykozlov
Copy link
Contributor

Description

The deepaas-cli is updated to properly work with "required" in marshmallow fields. Also conversion from marshmallow types to python types is generally improved. The returned after "train" method JSON document includes now parameters similar to JSON document returned by the REST API

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Update feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details for
your test configuration

  • Tested with real code
  • Tests of DEEPaaS are executed (tox run), no issues related to the update found

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@vykozlov
Copy link
Contributor Author

What I see in my local tests:

py310: OK (3.20=setup[0.06]+cmd[0.55,2.60] seconds)
flake8: OK (0.83=setup[0.02]+cmd[0.81] seconds)
black: OK (0.89=setup[0.02]+cmd[0.87] seconds)
bandit: OK (0.78=setup[0.01]+cmd[0.76] seconds)
pip-missing-reqs: OK (1.38=setup[0.02]+cmd[1.36] seconds)
pypi: OK (0.76=setup[0.01]+cmd[0.75] seconds)
congratulations :) (7.95 seconds)

@alvarolopez
Copy link
Collaborator

@vykozlov there was a problem in the RTD configuration (cf. readthedocs/readthedocs.org#5105) that is now solved in main, making your PR build happy

@alvarolopez alvarolopez merged commit 1f3d2f8 into master Sep 27, 2023
4 checks passed
@alvarolopez alvarolopez deleted the update_cli branch September 27, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants