Bg Changer Project #1143
Bg Changer Project #1143
Conversation
A bg changer project made using react js and css
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request introduces a basic React background changer project to the Million.js website repository, which is inconsistent with the repository's purpose and structure.
- Completely replaces the existing Next.js-based website with a Vite-based React project in
/website/package.json - Removes custom Tailwind configurations, including animations and dark mode support, in
/website/tailwind.config.js - Introduces a new ESLint configuration in
/website/.eslintrc.cjsthat disables security-related rules - Adds new files (
index.html,vite.config.js) for a React project structure that doesn't align with the existing Million.js website - Lacks proper documentation and explanation for these sweeping changes, which could potentially break existing functionality
7 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings
| settings: { react: { version: '18.2' } }, | ||
| plugins: ['react-refresh'], | ||
| rules: { | ||
| 'react/jsx-no-target-blank': 'off', |
There was a problem hiding this comment.
logic: Disabling 'react/jsx-no-target-blank' rule may introduce security vulnerabilities. Consider keeping this rule enabled.
| @@ -0,0 +1,8 @@ | |||
| # background Changer using React | |||
There was a problem hiding this comment.
style: Consider capitalizing 'Background' for consistency
| Currently, two official plugins are available: | ||
|
|
||
| - [@vitejs/plugin-react](https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react/README.md) uses [Babel](https://babeljs.io/) for Fast Refresh | ||
| - [@vitejs/plugin-react-swc](https://github.com/vitejs/vite-plugin-react-swc) uses [SWC](https://swc.rs/) for Fast Refresh |
There was a problem hiding this comment.
style: This information about Vite plugins seems unrelated to the background changer project. Consider removing or replacing with project-specific details
| "react": "^18.3.1", | ||
| "react-dom": "^18.3.1" |
There was a problem hiding this comment.
logic: React version 18.3.1 does not exist. Use a valid version
| @@ -1,54 +1,11 @@ | |||
| /** @type {import('tailwindcss').Config} */ | |||
| module.exports = { | |||
| export default { | |||
There was a problem hiding this comment.
logic: Switching from CommonJS to ES modules may cause issues if the project isn't set up for ES modules
| plugins: [require('@tailwindcss/line-clamp')], | ||
| darkMode: 'class', | ||
| }; | ||
| plugins: [], |
There was a problem hiding this comment.
logic: Removal of '@tailwindcss/line-clamp' plugin might break existing layouts
A bg changer project made using react js and css
Please describe the changes this PR makes and why it should be merged:
Status
Semantic versioning classification: