Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote port forwarding #178

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

superstar54
Copy link
Member

Add a example command for remote port forwarding when user login in through a jump server.

@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.05 ⚠️

Comparison is base (d3c121f) 86.54% compared to head (f9faa7c) 86.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
- Coverage   86.54%   86.50%   -0.05%     
==========================================
  Files           9        9              
  Lines         907      904       -3     
==========================================
- Hits          785      782       -3     
  Misses        122      122              
Flag Coverage Δ
py-3.10 86.39% <100.00%> (-0.05%) ⬇️
py-3.11 86.39% <100.00%> (-0.05%) ⬇️
py-3.8 86.34% <100.00%> (-0.05%) ⬇️
py-3.9 86.45% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiidalab_launch/__main__.py 79.93% <100.00%> (-0.20%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@unkcpz
Copy link
Member

unkcpz commented May 29, 2023

Hi @superstar54, if this is ready, you can request for review next time. can you see the button on the left?
image

@@ -45,6 +45,11 @@

ssh {user}@{hostname} -NfL {port}:localhost:{port}

If you visit the remote machine through a jump server, you run (replace the J_IP with the jump server IP):

ssh -J {user}@J_IP {user}@{hostname} -NfL {port}:localhost:{port}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that possible to get the J_IP if you are already ssh to the remote through SSH, this command is suppose to be copy-paste and run.

@@ -87,7 +92,7 @@ def callback(ctx, param, value): # noqa: U100
)(cmd)


@click.group(context_settings={"help_option_names": ["-h", "--help"]})
@click.group()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase the branch? I guess you force push and override the new changes.

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@superstar54 thanks, just some minor request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants