Fix/traitlet structure fixes #381 blocked by #377 #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
observe("input_structure")
for more information, see https://pre-commit.ci
|
@cpignedoli why is this blocked by #377? Seems like this should be a separate fix? |
|
it is true but I implemented it on top of another blocked PR |
|
@cpignedoli let's try to move this PR somewhere. I see @danielhollas cherry-picked bc179c4 into a separate PR (#549). Is it the only relevant change that remains here? |
|
yes this is so old that for sure it has been fixed somewhere else somehow |
|
We checked the latest release of the AWB (2.1.0), and the bug is no more there. |
|
I close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #381
This fixes the setting of
self.structure = Nonewhen an action button is pressed for an importer ("SMILES" and "import from computer")Thanks, @danielhollas, I tried
self.structure = Nonejust in observe("input_structure") but this does not work still, I keep the modification also in that observe.