-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/traitlet structure fixes #381 blocked by #377 #383
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
observe("input_structure")
for more information, see https://pre-commit.ci
@cpignedoli why is this blocked by #377? Seems like this should be a separate fix? |
it is true but I implemented it on top of another blocked PR |
@cpignedoli let's try to move this PR somewhere. I see @danielhollas cherry-picked bc179c4 into a separate PR (#549). Is it the only relevant change that remains here? |
yes this is so old that for sure it has been fixed somewhere else somehow |
We checked the latest release of the AWB (2.1.0), and the bug is no more there. |
I close |
Fixes #381
This fixes the setting of
self.structure = None
when an action button is pressed for an importer ("SMILES" and "import from computer")Thanks, @danielhollas, I tried
self.structure = None
just in observe("input_structure") but this does not work still, I keep the modification also in that observe.