Windows bug fix #664
Open
Windows bug fix #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osteensco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes broken windows paths caused by #646.
Addresses Issues #659, #662.
For the record, on my previous PR I mentioned I was getting failing tests and the GH actions build process failed. This is still happening and I'm not sure what's really causing them. I think these things should be addressed but is probably out of scope of this PR. I'm not sure if it's from changes I made or not.
That being said, I manually tested this on a windows 10 environment and it worked for me. If your project folder has a space in it and you're on windows it might still break, idk.
If some of the others who experienced this issue could test this as well and leave a comment I think that would be really helpful to ensure this PR fixes the issue and nothing additional breaks.
@omarattia3143, @JasonGoemaat, @moboqe, @cosmtrek