Attempt to make ResilientDecoding work with Swift Concurrency #53
Conversation
[email protected]
Outdated
| @@ -0,0 +1,31 @@ | |||
| // swift-tools-version:5.8 | |||
There was a problem hiding this comment.
this swift tools version does not align with the name of this package file.
[email protected]
Outdated
| .target( | ||
| name: "ResilientDecoding", | ||
| dependencies: []), | ||
| .testTarget( | ||
| name: "ResilientDecodingTests", | ||
| dependencies: ["ResilientDecoding"]), | ||
| ] | ||
| ) | ||
|
|
||
| for target in package.targets { | ||
| var settings = target.swiftSettings ?? [] | ||
| settings.append(.enableExperimentalFeature("StrictConcurrency")) | ||
| target.swiftSettings = settings | ||
| } |
There was a problem hiding this comment.
If you're intending this file to be swift tools version 5.8, I'd recommend writing this as:
| .target( | |
| name: "ResilientDecoding", | |
| dependencies: []), | |
| .testTarget( | |
| name: "ResilientDecodingTests", | |
| dependencies: ["ResilientDecoding"]), | |
| ] | |
| ) | |
| for target in package.targets { | |
| var settings = target.swiftSettings ?? [] | |
| settings.append(.enableExperimentalFeature("StrictConcurrency")) | |
| target.swiftSettings = settings | |
| } | |
| .target( | |
| name: "ResilientDecoding", | |
| dependencies: [], | |
| swiftSettings: [ | |
| .enableUpcomingFeature("StrictConcurrency") | |
| ]), | |
| .testTarget( | |
| name: "ResilientDecodingTests", | |
| dependencies: ["ResilientDecoding"], | |
| swiftSettings: [ | |
| .enableUpcomingFeature("StrictConcurrency") | |
| ]) | |
| ] | |
| ) |
Note that this is an upcoming rather than experimental feature. In tools version 5.7, you indeed do need to call this experimental IIRC.
There was a problem hiding this comment.
With 5.8, this is still considered an experimental feature, so we need to keep it as . enableExperimentalFeature. I will inline it to the targets, however, as you suggest.
There was a problem hiding this comment.
Welp I may have some code in my own projects to update then
| @@ -234,12 +234,12 @@ public struct UnknownNovelValueError: Error { | |||
| /** | |||
| The raw value for which `init(rawValue:)` returned `nil`. | |||
| */ | |||
| public let novelValue: Any | |||
| public let novelValue: Sendable | |||
There was a problem hiding this comment.
Worth noting that this is a breaking change, and we should update the sample dependency management code in the README to match. Podspec needs bumping too.
There was a problem hiding this comment.
For sure, I see this being a minor version bump at a minimum.
|
I had a thought earlier this morning about trying to make this work via conditional conformance instead of requiring all values to be Edit: Not feasible due to all the internal generic objects used in DEBUG builds. Might be possible for RELEASE but I think enforcing |
| onlyGenerateCoverageForSpecifiedTargets = "YES"> | ||
| <CodeCoverageTargets> | ||
| <BuildableReference | ||
| BuildableIdentifier = "primary" | ||
| BlueprintIdentifier = "ResilientDecoding" | ||
| BuildableName = "ResilientDecoding" | ||
| BlueprintName = "ResilientDecoding" | ||
| ReferencedContainer = "container:"> | ||
| </BuildableReference> | ||
| </CodeCoverageTargets> |
There was a problem hiding this comment.
Ensures code coverage numbers are accurate - previously was including the test target coverage too.
| @@ -234,12 +234,12 @@ public struct UnknownNovelValueError: Error { | |||
| /** | |||
| The raw value for which `init(rawValue:)` returned `nil`. | |||
| */ | |||
| public let novelValue: Any | |||
| public let novelValue: Sendable | |||
There was a problem hiding this comment.
For sure, I see this being a minor version bump at a minimum.
|
Hey, major bump is technically correct since the version would contain breaking changes, but since this library is perfect as it is and hasn't needed any releases in a quite a long time a minor one is fine as well IMO, though that's up to @dfed. @bdbergeron could you please update the version in ResilientDecoding.podspec? Also, @dfed what changes do you envision for the README, info about the new version requiring By the way, since I'm already writing this, I want to thank you @dfed for this wonderful utility and @bdbergeron for the preparation for strict Swift concurrency. ❤️ |
Starting a conversation about updating this library to support Swift Concurrency, namely
Sendablevalues, so consumers don't have to use@preconcurrecny import ResilientDecoding. This simple "build and fix" approach may not be the most ideal, as it requires the wrapped property to no longer simply be aDecodablebut also aSendablevalue. However, it's worth having the conversation of what the future of this library looks like in a modern Swift world, so here I'm proposing the first steps to getting us to a more modern Swift syntax.