Add ShowkaseBrowserFragment to be used as a replacement of ShowkaseBrowserActivity #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamedHarmoush
changed the title
|
Hello @vinaygaba Thank you! |
|
@MohamedHarmoush What do you think about exposing the entry point |
|
@marcorighini Actually , it's nice idea. |
|
@marcorighini as you suggested
as an entry point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request (PR) introduces the ShowkaseBrowserFragment.
The purpose: of this addition is to provide developers with an alternative to the existing ShowkaseBrowserActivity when following a single activity architecture. The ShowkaseBrowserFragment offers a more flexible and reusable way to integrate the Showkase browser functionality within their Android applications, accommodating various architectural preferences and enhancing the overall usability of the Showkase library.