Fix joins to include partial null results #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrooks-stripe
force-pushed
the
jbrooks-partial-null-results
branch
from
8f4f080 to
f9a70ee
Compare
nikhilsimha
approved these changes
May 25, 2024
andrewlee-stripe
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We found some online/offline inconsistencies with GroupBys when using multiple keys where some contained nulls. The online behavior would aggregate on (key1, null), whereas the offline would result in nulls if any keys were null.
This corrects the offline joins to match the online behavior of partial aggregations.
Why / Goal
Test Plan
Checklist
Reviewers