Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint v9 support #2961

Open
7 of 14 tasks
ljharb opened this issue Apr 6, 2024 · 14 comments
Open
7 of 14 tasks

eslint v9 support #2961

ljharb opened this issue Apr 6, 2024 · 14 comments

Comments

@ljharb
Copy link
Collaborator

ljharb commented Apr 6, 2024 •
edited
Loading

(see also #2478, #2223, #2036, #1834, #1447)

eslint v9 was released on 2024.04.05.

The current plan is, if possible, to release a new semver-minor of both configs, that supports 7 || 8 || 9.

Note that this is different from whether flat config is supported or not by these plugins, and from whether this project will convert to flat config.

The timeframe for eslint v9 support is "not as soon as you would like, but as soon as we can".
Please accept this, and please add no noise to this thread beyond emoji reactions - distractions won't help anyone get the work done any faster.

Please do not file additional issues and do not file pull requests attempting to add support - please, instead, continue to use eslint v8 until such time as our configs support v9.

Peer Dep eslint combined v7, v8, and v9 support released:
@epicserve epicserve mentioned this issue Apr 6, 2024
Open
@ljharb ljharb pinned this issue Apr 8, 2024
This was referenced Apr 8, 2024
Closed
Closed
Closed
Closed
Closed
tripodsan added a commit to adobe/helix-shared that referenced this issue Apr 9, 2024
@tripodsan
chore: limit eslint until airbnb released support
de3a8f6 
see airbnb/javascript#2961
@tripodsan tripodsan mentioned this issue Apr 9, 2024
Merged
tripodsan added a commit to adobe/helix-shared that referenced this issue Apr 9, 2024
@tripodsan
chore: limit eslint until airbnb released support (#924)
0133730 
see airbnb/javascript#2961
@eliashaeussler eliashaeussler mentioned this issue Apr 14, 2024
Merged
1 task
@qwerty287 qwerty287 mentioned this issue Apr 15, 2024
Merged
1 task
nickjj added a commit to nickjj/docker-node-example that referenced this issue Apr 16, 2024
@nickjj
Revert back to eslint 8.X
6a02f23 
Certain extensions aren't compatible yet with 9.X such as:

  airbnb/javascript#2961
@birdofpreyru birdofpreyru mentioned this issue Apr 17, 2024
Open
@acelaya acelaya mentioned this issue Apr 21, 2024
Closed
2 tasks
@will-byrne will-byrne mentioned this issue Apr 22, 2024
Closed
1 task
@marcus-bcl marcus-bcl mentioned this issue Apr 25, 2024
Closed
1 task
@RobinTail RobinTail mentioned this issue Apr 27, 2024
Closed
@DianaSuvorova DianaSuvorova mentioned this issue Apr 28, 2024
Closed
@christianlupus christianlupus mentioned this issue May 1, 2024
Closed
@filmaj filmaj mentioned this issue May 1, 2024
Closed
@pplancq pplancq mentioned this issue May 6, 2024
Open
16 tasks
@CloudNStoyan CloudNStoyan mentioned this issue May 13, 2024
Merged
This was referenced May 20, 2024
Closed
Closed
Closed
Closed
Closed
@wagnerand wagnerand mentioned this issue May 28, 2024
Open
@solaris007 solaris007 mentioned this issue Jun 4, 2024
Open
@enell enell mentioned this issue Sep 12, 2024
Closed
1 task
@hubjongit
Copy link

hubjongit commented Sep 14, 2024 •
edited
Loading

The eslint-plugin-react-hooks PR is merged and available at least in canary release (can be checked off?), and flat config support for it has a PR now waiting to be merged (can be linked). @michaelfaith really putting in the work to help get all these pre-reqs complete.
Is Airbnb support gonna happen soon?

@mauroalderete mauroalderete mentioned this issue Sep 19, 2024
Open
@JakobLierman JakobLierman mentioned this issue Sep 23, 2024
Open
@deborahgu deborahgu mentioned this issue Sep 24, 2024
Open
1 task
@xatier xatier mentioned this issue Sep 25, 2024
Closed
@3vorp 3vorp mentioned this issue Sep 26, 2024
Closed
Venryx added a commit to Venryx/eslint-config-vbase that referenced this issue Sep 26, 2024
@Venryx
* Mostly (at least work-wise) updated this vbase config to eslint v9.…
a2179c1 
… (still waiting on eslint-config-airbnb-base to be updated to v9, for it to be complete however: airbnb/javascript#2961)
This was referenced Sep 26, 2024
Draft
Open
@david-venhoff david-venhoff mentioned this issue Sep 30, 2024
Open
@saseungmin saseungmin mentioned this issue Oct 1, 2024
Open
@mangs mangs mentioned this issue Oct 2, 2024
Merged
3 tasks
tomasvotava added a commit to tomasvotava/churrizard that referenced this issue Oct 2, 2024
@tomasvotava
chore(deps): resolve dependencies
be3e101 
eslint airbnb config does not support eslint ^9 yet
Until airbnb/javascript#2961 is closed
tomasvotava added a commit to tomasvotava/churrizard that referenced this issue Oct 2, 2024
@dependabot @tomasvotava
chore(deps): bump the all group with 11 updates (#2)
56a0af1 
* chore(deps): bump the all group with 11 updates

Bumps the all group with 11 updates:

| Package | From | To |
| --- | --- | --- |
| [firebase](https://github.com/firebase/firebase-js-sdk) | `10.9.0` | `10.14.0` |
| [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) | `7.24.3` | `7.25.2` |
| [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) | `7.24.3` | `7.25.4` |
| [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) | `29.5.12` | `29.5.13` |
| [eslint](https://github.com/eslint/eslint) | `8.57.0` | `9.11.1` |
| [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) | `2.29.1` | `2.30.0` |
| [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) | `27.9.0` | `28.8.3` |
| [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) | `48.2.1` | `50.3.0` |
| [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) | `5.1.3` | `5.2.1` |
| [jsdoc](https://github.com/jsdoc/jsdoc) | `4.0.2` | `4.0.3` |
| [prettier](https://github.com/prettier/prettier) | `3.2.5` | `3.3.3` |


Updates `firebase` from 10.9.0 to 10.14.0
- [Release notes](https://github.com/firebase/firebase-js-sdk/releases)
- [Changelog](https://github.com/firebase/firebase-js-sdk/blob/main/CHANGELOG.md)
- [Commits](https://github.com/firebase/firebase-js-sdk/compare/[email protected]@10.14.0)

Updates `@babel/core` from 7.24.3 to 7.25.2
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.25.2/packages/babel-core)

Updates `@babel/preset-env` from 7.24.3 to 7.25.4
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.25.4/packages/babel-preset-env)

Updates `@types/jest` from 29.5.12 to 29.5.13
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest)

Updates `eslint` from 8.57.0 to 9.11.1
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.57.0...v9.11.1)

Updates `eslint-plugin-import` from 2.29.1 to 2.30.0
- [Release notes](https://github.com/import-js/eslint-plugin-import/releases)
- [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md)
- [Commits](import-js/eslint-plugin-import@v2.29.1...v2.30.0)

Updates `eslint-plugin-jest` from 27.9.0 to 28.8.3
- [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases)
- [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md)
- [Commits](jest-community/eslint-plugin-jest@v27.9.0...v28.8.3)

Updates `eslint-plugin-jsdoc` from 48.2.1 to 50.3.0
- [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases)
- [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc)
- [Commits](gajus/eslint-plugin-jsdoc@v48.2.1...v50.3.0)

Updates `eslint-plugin-prettier` from 5.1.3 to 5.2.1
- [Release notes](https://github.com/prettier/eslint-plugin-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md)
- [Commits](prettier/eslint-plugin-prettier@v5.1.3...v5.2.1)

Updates `jsdoc` from 4.0.2 to 4.0.3
- [Release notes](https://github.com/jsdoc/jsdoc/releases)
- [Changelog](https://github.com/jsdoc/jsdoc/blob/4.0.3/CHANGES.md)
- [Commits](jsdoc/jsdoc@4.0.2...4.0.3)

Updates `prettier` from 3.2.5 to 3.3.3
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.2.5...3.3.3)

---
updated-dependencies:
- dependency-name: firebase
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: "@babel/core"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: "@babel/preset-env"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: "@types/jest"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: all
- dependency-name: eslint-plugin-import
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: eslint-plugin-jest
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: all
- dependency-name: eslint-plugin-jsdoc
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: all
- dependency-name: eslint-plugin-prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: jsdoc
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(deps): resolve dependencies

eslint airbnb config does not support eslint ^9 yet
Until airbnb/javascript#2961 is closed

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tomas Votava <[email protected]>
@JorabekDev

This comment was marked as spam.

Sign in to view
@mangs mangs mentioned this issue Oct 7, 2024
Closed
3 tasks
@tiavina-mika

This comment was marked as spam.

Sign in to view
@Aluisio
Copy link

Aluisio commented Oct 11, 2024

eslint-plugin-react-hooks stable version 5.0.0 has just been released 😃

@michaelfaith
Copy link

Really stoked to see that! It doesn't, however provide flat config support. So, still a bit more there needed.

@efoken
Copy link

efoken commented Oct 13, 2024

But @michaelfaith, I am not sure if flat config support is actually needed for eslint-plugin-react-hooks!? Because it only contains 2 rules and the plugin and these things are manually set in Airbnb config without an import or something, so I don't see any need for flat config support.

@ljharb
Copy link
Collaborator Author

ljharb commented Oct 13, 2024

If we want to expose a flat config, then we’d need it to have one too.

@michaelfaith
Copy link

Ah, that's a fair point. If the config isn't used, then that wouldn't be a blocker.

@michaelfaith
Copy link

michaelfaith commented Oct 13, 2024 •
edited
Loading

If we want to expose a flat config, then we’d need it to have one too.

Looks like we hit submit at the same time? haha I think it'd actually be possible without their own flat config, unless I'm missing something. Looking at how this library is using the react-hooks plugin, it's only using the rules directly, rather than extending one of its configs. So mapping that same thing to a flat config wouldn't require them to actually have a flat config of their own; just v9 / flat config compatible rules.

@harshithmohan harshithmohan mentioned this issue Oct 13, 2024
Open
@xatier xatier mentioned this issue Oct 16, 2024
Closed
@jerome-benoit jerome-benoit mentioned this issue Oct 16, 2024
Closed
@bedrich-schindler bedrich-schindler mentioned this issue Oct 16, 2024
Open
@neymanushka neymanushka mentioned this issue Oct 17, 2024
Open
@xander-marjoram xander-marjoram mentioned this issue Oct 18, 2024
Draft
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests