Update dependencies #3082
Open
Update dependencies #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking Changes of direct python deps: - Cryptography: * Dropped support for OpenSSL < 1.1.1e * Dropped support for LibreSSL < 3.8 - Icalendar: * Use zoneinfo instead of pytz
We were using the typ `StateUpdater<_>` for setters, but the type of `StateUpdater<T>` just resolves to `T | ((prevState: T) => T)`, which means that it is not guaranteed to be callable. The preact documentation is not really helpful: https://preactjs.com/guide/v10/typescript/#typing-hooks But in the source of `useState`, the setter is typed as `Dispatch<StateUpdater<T>>`, so I decide to use the same type.
david-venhoff
requested review from
PeterNerlich,
ulliholtgrave,
JoeyStk and
MizukiTemma
Due to many positives, I changed the value from 5 to 6 and manually annotated the remaining occurrences with too many positives, in the hopes that we will fix that at some point :)
david-venhoff
force-pushed
the
update/dependencies-2024-09-30
branch
from
057e09b
to
f48a605
Compare
|
Code Climate has analyzed commit f48a605 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 82.5% (0.0% change). View more on Code Climate. |
|
@david-venhoff Thank you very much! 😊 I don't think that the changes to cryptography are affecting us. |
charludo
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This pr updates our dependencies, which includes multiple breaking changes that I attempted to fix.
Proposed changes
Side effects
I also noticed 2 direct python dependencies that had a major version bump. I did some testing and don't think any functionality of the cms was broken.
Running
./tools/eslintnow produces a deprecation warning. I tried updating eslint, but we depend oneslint-config-airbnbwhich does not support modern eslint versions. At least there is an active issue for that: airbnb/javascript#2961I think we can accept this deprecation warning for the time being and open an issue to update eslint, but I am open to other opinions :)
Resolved issues
Fixes: /
Pull Request Review Guidelines