Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Progress Dialog If Actions Done/NotDone #63

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Feat: Progress Dialog If Actions Done/NotDone #63

merged 3 commits into from
Sep 30, 2024

Conversation

mlajkim
Copy link
Contributor

@mlajkim mlajkim commented Sep 29, 2024 •
edited
Loading

Background

Renders the following dialog if changes made:
image

Checklist Before PR Review

  • The following has been handled:
    • Draft is set for this PR
    • Title is checked
    • Background is filled
    • Assignee is set
    • Labels are set
    • development is linked if related issue exists

Checklist (Right Before PR Review Request)

  • The following has been handled:
    • Final Operation Check is done
    • Make this PR as an open PR

Checklist (Reviewers)

  • Check if there are any other missing TODOs that are not yet listed
  • Review Code
  • Every item on the checklist has been addressed accordingly
  • If development is associated to this PR, you must check if every TODOs are handled

@mlajkim mlajkim added the enhancement New feature or request label Sep 29, 2024
@mlajkim mlajkim self-assigned this Sep 29, 2024
@mlajkim mlajkim marked this pull request as draft September 29, 2024 04:18
@mlajkim mlajkim marked this pull request as draft September 29, 2024 04:18
mlajkim
mlajkim commented Sep 30, 2024
View reviewed changes
Copy link
Contributor Author

@mlajkim mlajkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda wish the dialog appears only when app is loaded; but it is fine for now

@mlajkim mlajkim marked this pull request as ready for review September 30, 2024 00:35
@mlajkim mlajkim merged commit 2b04116 into main Sep 30, 2024
1 check passed
@mlajkim mlajkim deleted the feat/dialog-for-achivement branch September 30, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mlajkim mlajkim

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mlajkim