Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dialog only when actionGroupAchievedPercentSelector #64

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

mlajkim
Copy link
Contributor

@mlajkim mlajkim commented Oct 2, 2024

Background

Dialog opens/closes within few seconds, as the action group data is changed once open

Checklist Before PR Review

  • The following has been handled:
    • Draft is set for this PR
    • Title is checked
    • Background is filled
    • Assignee is set
    • Labels are set
    • development is linked if related issue exists

Checklist (Right Before PR Review Request)

  • The following has been handled:
    • Final Operation Check is done
    • Make this PR as an open PR

Checklist (Reviewers)

  • Check if there are any other missing TODOs that are not yet listed
  • Review Code
  • Every item on the checklist has been addressed accordingly
  • If development is associated to this PR, you must check if every TODOs are handled

@mlajkim mlajkim self-assigned this Oct 2, 2024
@mlajkim mlajkim added the bugfix Something isn't working label Oct 2, 2024
Copy link
Contributor Author

@mlajkim mlajkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@mlajkim mlajkim merged commit 27666af into main Oct 4, 2024
1 check passed
@mlajkim mlajkim deleted the fix/dialog-only-when-all-ready branch October 4, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant