PR feedback

ajna-finance · Dec 12, 2023 · 07c08db · 07c08db
1 parent ceedd22
commit 07c08db
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/tests/INVARIANTS.md b/tests/INVARIANTS.md
@@ -73,7 +73,7 @@
 - **RE6**:  Reserves are unchanged by removing collateral token from a bucket
 - **RE7**:  Reserves increase by bond penalty/reward plus borrower penalty on take above TP.
 - **RE8**:  Reserves increase by bond penalty/reward plus borrower penalty on bucket takes above TP.
-- **RE9**:  Reserves unchanged by takes and bucket takes below TP(at the time of kick).
+- **RE9**:  Reserves unchanged by takes and bucket takes below TP (at the time of kick).
 - **RE10**: Reserves increase by origination fee: max(1 week interest, 0.05% of borrow amount), on draw debt
 - **RE11**: Reserves decrease by claimableReserves by kickReserveAuction
 - **RE12**: Reserves decrease by amount of reserve used to settle a auction

diff --git a/tests/forge/regression/ERC20Pool/RegressionTestReservesERC20Pool.t.sol b/tests/forge/regression/ERC20Pool/RegressionTestReservesERC20Pool.t.sol
@@ -1428,7 +1428,10 @@ contract RegressionTestReserveWith8CollateralPrecisionERC20Pool is ReserveERC20P
         invariant_reserves();
     }
 
-    // FIXME: incorrect reserves change
+    /*
+        Test failed because RE9 was incorrectly implemented that take below tp (at time of take) doesn't change reserves.
+        Fixed by updating RE9 implementation to `Reserves are unchanged by take below tp (at time of kick)`.
+    */
     function test_regression_failure_reserves_on_bucketTake() external {
         _reserveERC20PoolHandler.bucketTake(21318, 17209, false, 7256, 2112895574);
         _reserveERC20PoolHandler.failed();