Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HTP calculation in invariant logic #1042

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Fix HTP calculation in invariant logic #1042

merged 4 commits into from
Dec 18, 2023

Conversation

grandizzy
Copy link
Contributor

Description

Invariant invariant_fenwick was failing because invariant logic for interest accrual was using the pending inflator to calculate HTP instead current pool inflator.

Purpose

Impact

Tasks

  • Changes to protocol contracts are covered by unit tests executed by CI.
  • Protocol contract size limits have not been exceeded.
  • Gas consumption for impacted transactions have been compared with the target branch, and nontrivial changes cited in the Impact section above.
  • Scope labels have been assigned as appropriate.
  • Invariant tests have been manually executed as appropriate for the nature of the change.

@grandizzy grandizzy changed the title 1810 invariant failures Fix HTP calculation in invariant logic Dec 18, 2023
MikeHathaway
MikeHathaway approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@MikeHathaway MikeHathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EdNoepel
EdNoepel approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@EdNoepel EdNoepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently testing this branch on parvati.

mattcushman
mattcushman approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@mattcushman mattcushman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@EdNoepel EdNoepel merged commit 7506ef5 into develop Dec 18, 2023
3 checks passed
@EdNoepel EdNoepel deleted the 1810-invariant-failures branch December 18, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdNoepel EdNoepel EdNoepel approved these changes

@mattcushman mattcushman mattcushman approved these changes

@MikeHathaway MikeHathaway MikeHathaway approved these changes

@prateek105 prateek105 Awaiting requested review from prateek105

@ith-harvey ith-harvey Awaiting requested review from ith-harvey

Assignees
No one assigned
Labels
Priority: Low Scope: Tests Status: Ready for Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grandizzy @MikeHathaway @mattcushman @EdNoepel