Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created bucket instance to test Buckets library #1053

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Conversation

ith-harvey
Copy link
Contributor

@ith-harvey ith-harvey commented Jan 4, 2024

Description

Purpose

  • This code was not tested, now it is.

Impact

  • Just updated tests no impact to protocol

Tasks

  • Changes to protocol contracts are covered by unit tests executed by CI.
  • Protocol contract size limits have not been exceeded.
  • Gas consumption for impacted transactions have been compared with the target branch, and nontrivial changes cited in the Impact section above.
  • Scope labels have been assigned as appropriate.
  • Invariant tests have been manually executed as appropriate for the nature of the change.

@ith-harvey ith-harvey marked this pull request as ready for review January 4, 2024 14:39
@ith-harvey ith-harvey changed the title created bucket instance to test Buckets library Created bucket instance to test Buckets library Jan 4, 2024
Copy link
Contributor

@prateek105 prateek105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

three methods lpToCollateral, lpToQuoteTokens and getExchangeRate from Buckets library not yet covered.

@ith-harvey
Copy link
Contributor Author

three methods lpToCollateral, lpToQuoteTokens and getExchangeRate from Buckets library not yet covered.

Copy link
Contributor

@prateek105 prateek105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@EdNoepel EdNoepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@MikeHathaway MikeHathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ith-harvey ith-harvey merged commit 3fa8290 into develop Jan 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants