-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created bucket instance to test Buckets library #1053
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
three methods lpToCollateral
, lpToQuoteTokens
and getExchangeRate
from Buckets
library not yet covered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Buckets.sol
lpToCollateral
,lpToQuoteTokens
andgetExchangeRate
as they are tested in poolInfoUtils.lpToCollateral
: https://github.com/ajna-finance/contracts/blob/99c89e74023c8ef7b3adf58ed19cb2f3e3914cdf/tests/forge/unit/ERC20Pool/ERC20PoolInfoUtils.t.sol#L323-L324lpToQuoteTokens
: https://github.com/ajna-finance/contracts/blob/99c89e74023c8ef7b3adf58ed19cb2f3e3914cdf/tests/forge/unit/ERC20Pool/ERC20PoolInfoUtils.t.sol#L323-L324getExchangeRate
: https://github.com/ajna-finance/contracts/blob/99c89e74023c8ef7b3adf58ed19cb2f3e3914cdf/tests/forge/unit/ERC20Pool/ERC20PoolInfoUtils.t.sol#L208Purpose
Impact
Tasks