Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invariants Improvement #1054

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Invariants Improvement #1054

merged 2 commits into from
Jan 11, 2024

Conversation

prateek105
Copy link
Contributor

@prateek105 prateek105 commented Jan 8, 2024 •
edited
Loading

Description

  • Reduce MAX_POOL_DEBT to 1e32.
  • Add loan settlement for settleable borrowers if pooldebt > MAX_POOL_DEBT.
  • Fix collateral to pledge calculations to calculate collateral to pledge at least collateral scale.

Purpose

Impact

Tasks

  • Changes to protocol contracts are covered by unit tests executed by CI.
  • Protocol contract size limits have not been exceeded.
  • Gas consumption for impacted transactions have been compared with the target branch, and nontrivial changes cited in the Impact section above.
  • Scope labels have been assigned as appropriate.
  • Invariant tests have been manually executed as appropriate for the nature of the change.

@prateek105 prateek105 mentioned this pull request Jan 9, 2024
Open
5 tasks
MikeHathaway
MikeHathaway approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@MikeHathaway MikeHathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prateek105 prateek105 merged commit f0b163c into reserves-bucket-take Jan 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grandizzy grandizzy grandizzy approved these changes

@MikeHathaway MikeHathaway MikeHathaway approved these changes

@ith-harvey ith-harvey Awaiting requested review from ith-harvey

@mattcushman mattcushman Awaiting requested review from mattcushman

@EdNoepel EdNoepel Awaiting requested review from EdNoepel

Assignees
No one assigned
Labels
Scope: Tests Status: Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prateek105 @MikeHathaway @grandizzy