Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _assertAuction to check borrower t0ReserveSettleAmount and add invariant A10 #1056

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

prateek105
Copy link
Contributor

@prateek105 prateek105 commented Jan 10, 2024

Description

  • Update auctionInfo to return borrower t0ReserveSettleAmount from the pool.
  • Update _assertAuction to check borrower t0ReserveSettleAmount.
  • Add invariant A10: Upon kick t0ReserveSettleAmount should be set to BorrowerT0Debt * borrowFeeRate / 2 for the kicked borrower
  • Update LOANS_COUNT in ERC20PoolPositionsInvariants from 500 to 320 to resolve the EvmError: MemoryLimitOOG error while running tests. This started to fail because auctionInfo updated to return t0ReserveSettleAmount now.

Purpose

Impact

  • This PR includes src changes to return t0ReserveSettleAmount. This PR can be used for testing only to avoid contracts redeployment as there is no real need for user to know how much bad debt can be settled through reserves at the time of settlement.

Tasks

  • Changes to protocol contracts are covered by unit tests executed by CI.
  • Protocol contract size limits have not been exceeded.
  • Gas consumption for impacted transactions have been compared with the target branch, and nontrivial changes cited in the Impact section above.
  • Scope labels have been assigned as appropriate.
  • Invariant tests have been manually executed as appropriate for the nature of the change.

@prateek105 prateek105 marked this pull request as ready for review January 12, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant