Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2086 enforce password requirements for admin user #2098

Merged

Conversation

manuel-rw
Copy link
Collaborator

Category

Bugfix

Overview

Reuse same validation as for security meter

Issue Number (if applicable)

Related issue: #2086

@manuel-rw manuel-rw self-assigned this Aug 4, 2024
@manuel-rw manuel-rw added the 🐛 Bug Something isn't working label Aug 4, 2024
@manuel-rw manuel-rw linked an issue Aug 4, 2024 that may be closed by this pull request
4 tasks
Copy link

github-actions bot commented Aug 4, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 17.26% 5620 / 32554
🔵 Statements 17.26% 5620 / 32554
🔵 Functions 6.38% 33 / 517
🔵 Branches 37.32% 134 / 359
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/validations/user.ts 100% 100% 0% 100%
Generated in workflow #6809

@manuel-rw manuel-rw merged commit 3de04bd into dev Aug 4, 2024
4 checks passed
@manuel-rw manuel-rw deleted the fix/#2086-enforce-password-requirements-for-admin-user branch August 4, 2024 15:47
truecharts-admin referenced this pull request in truecharts/public Sep 2, 2024
…c13f04c by renovate (#25798)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/ajnart/homarr](https://redirect.github.com/ajnart/homarr) |
patch | `0.15.3` -> `0.15.4` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>ajnart/homarr (ghcr.io/ajnart/homarr)</summary>

###
[`v0.15.4`](https://redirect.github.com/ajnart/homarr/releases/tag/v0.15.4)

[Compare
Source](https://redirect.github.com/ajnart/homarr/compare/v0.15.3...v0.15.4)

> \[!NOTE]\
> We've been working actively on working torwards version 1.0 which will
include many improvements to performance, security and the overall look
& feel of Homarr. It will greatly overhaul the technical architecture of
Homarr. This work is done by volunteers. Please consider supporting our
work via donations at https://opencollective.com/homarr

> \[!CAUTION]\
> We are **dropping support for armv7**. Old Raspberry Pi and arm
devices are no longer supported by some of our upstream dependencies.
> Our building framework for 1.0 also doesn't support armv7. This change
will only affect a very small amount of devices.
> We **recommend you to upgrade to a newer architecture** if you are
affected by this change. Cheap SBC's can be bought for very cheap that
support arm64.

#### Disable PiHole & AdGuard Home temporarily

Instead of permanently disabling them, Homarr can now disable them for a
certain time period: <img width="334"
alt="326053459-ca5d39cf-d53c-4597-b5e6-40288e51f66d"
src="https://github.com/user-attachments/assets/82c8a053-b8b9-4e9f-91bc-6e51b326ea25">

#### Proxmox uptime

The health monitoring widget can now display the uptime of your Proxmox
system:

![351717193-215cb6e2-5d9f-4884-9e44-2b1fd91e71cf](https://redirect.github.com/user-attachments/assets/a5c12fe3-7979-44a6-980d-84ad867af66b)

#### What's Changed

- Add `key` for custom favicon by
[@&#8203;ajnart](https://redirect.github.com/ajnart) in
[https://github.com/ajnart/homarr/pull/2052](https://redirect.github.com/ajnart/homarr/pull/2052)
- Add New Language Arabic by
[@&#8203;bo3bdo](https://redirect.github.com/bo3bdo) in
[https://github.com/ajnart/homarr/pull/2051](https://redirect.github.com/ajnart/homarr/pull/2051)
- Feature: Add dns disable timer by
[@&#8203;hillaliy](https://redirect.github.com/hillaliy) in
[https://github.com/ajnart/homarr/pull/2029](https://redirect.github.com/ajnart/homarr/pull/2029)
- New Crowdin updates by
[@&#8203;ajnart](https://redirect.github.com/ajnart) in
[https://github.com/ajnart/homarr/pull/2038](https://redirect.github.com/ajnart/homarr/pull/2038)
- feat: add indexers site hyperlink by
[@&#8203;hillaliy](https://redirect.github.com/hillaliy) in
[https://github.com/ajnart/homarr/pull/2061](https://redirect.github.com/ajnart/homarr/pull/2061)
- feat: add Proxmox Uptime View by
[@&#8203;JasonLeeB06](https://redirect.github.com/JasonLeeB06) in
[https://github.com/ajnart/homarr/pull/2092](https://redirect.github.com/ajnart/homarr/pull/2092)
- fix:
[#&#8203;2086](https://redirect.github.com/ajnart/homarr/issues/2086)
enforce password requirements for admin user by
[@&#8203;manuel-rw](https://redirect.github.com/manuel-rw) in
[https://github.com/ajnart/homarr/pull/2098](https://redirect.github.com/ajnart/homarr/pull/2098)
- fix:
[#&#8203;1707](https://redirect.github.com/ajnart/homarr/issues/1707)
refech interval app pings by
[@&#8203;manuel-rw](https://redirect.github.com/manuel-rw) in
[https://github.com/ajnart/homarr/pull/2097](https://redirect.github.com/ajnart/homarr/pull/2097)

#### New Contributors

- [@&#8203;bo3bdo](https://redirect.github.com/bo3bdo) made their first
contribution in
[https://github.com/ajnart/homarr/pull/2051](https://redirect.github.com/ajnart/homarr/pull/2051)
- [@&#8203;JasonLeeB06](https://redirect.github.com/JasonLeeB06) made
their first contribution in
[https://github.com/ajnart/homarr/pull/2092](https://redirect.github.com/ajnart/homarr/pull/2092)

**Full Changelog**:
ajnart/homarr@v0.15.3...v0.15.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6WyJhdXRvbWVyZ2UiLCJ1cGRhdGUvZG9ja2VyL2dlbmVyYWwvbm9uLW1ham9yIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Password requirements described as not forced but they actually are
2 participants