DXE-2682 Removing empty body default #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstopka
changed the title
|
Hi @stuartio, Thank you for sharing this improvement with us and opening the PR. As you can see, one of the tests is failing. May I ask you to make sure this change is covered by tests and the failing one is adjusted? Thanks, |
dstopka
changed the title
wzagrajcz
approved these changes
Sep 12, 2023
dstopka
approved these changes
Sep 12, 2023
|
@stuartio, thanks again for your contribution. I updated the failing test and now everything is ready for merging. It'll be a part of the upcoming release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behaviour adds an empty string as the body for all requests where the body is not specified. On zero length POSTs (e.g. https://techdocs.akamai.com/iam-api/reference/post-client-credentials-deactivate) this breaks the EdgeGrid auth calculation.