Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing timebucket from messages table #399

Closed
chbatey opened this issue Sep 19, 2018 · 2 comments
Closed

Consider removing timebucket from messages table #399

chbatey opened this issue Sep 19, 2018 · 2 comments
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:events-by-tag
Milestone
1.0.0-RC2

Comments

@chbatey
Copy link
Member

chbatey commented Sep 19, 2018

Or perhaps just the primary key. It was added for the materialized view eventsByTag impl which we've now removed.
@chbatey chbatey added help wanted 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted labels Sep 19, 2018
@johanandren johanandren changed the title Consider removing timebukcet from messages table Consider removing timebucket from messages table Sep 19, 2018
@patriknw
Copy link
Member

Does this mean that we would remove it from default table definition, but still look for the column in and adjust statements to if if the column is defined or not?

I'm not sure it's worth it?

@patriknw patriknw mentioned this issue Apr 3, 2020
Open
@patriknw
Copy link
Member

patriknw commented Apr 3, 2020

This might help for working around the CosmosDB delete problem #764

It should be possible to only have the timebucket in the tag view, created by the tag writer from the timeUuid.

@patriknw patriknw added this to the 1.0.0 milestone Apr 3, 2020
patriknw added a commit that referenced this issue Apr 6, 2020
@patriknw
Remove timebucket from clustering column, #399
1957a2e 
* originally there because of the materialized view
* for old table definitions it must be set
* would be difficult to remove it entirely from the table
  because then we would have to maintain two different insert statements
  depending on if the table defined the column or not, meaning that we
  would have to do some fake query when starting up to check if the column
  is defined
@patriknw patriknw mentioned this issue Apr 6, 2020
Merged
patriknw added a commit that referenced this issue Apr 7, 2020
@patriknw
Remove timebucket from clustering column, #399
982c8e5 
* originally there because of the materialized view
* for old table definitions it must be set
* would be difficult to remove it entirely from the table
  because then we would have to maintain two different insert statements
  depending on if the table defined the column or not, meaning that we
  would have to do some fake query when starting up to check if the column
  is defined
patriknw added a commit that referenced this issue Apr 7, 2020
@patriknw
Remove timebucket from clustering column, #399 (#766)
7f2ad5d 
* Remove timebucket from clustering column, #399

* originally there because of the materialized view
* for old table definitions it must be set
* would be difficult to remove it entirely from the table
  because then we would have to maintain two different insert statements
  depending on if the table defined the column or not, meaning that we
  would have to do some fake query when starting up to check if the column
  is defined

* fix CassandraEventUpdateSpec
@patriknw patriknw closed this as completed Apr 7, 2020
@patriknw patriknw modified the milestones: 1.0.0, 1.0-RC2 Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:events-by-tag
Projects
None yet
Milestone
1.0.0-RC2
Development

No branches or pull requests
2 participants
@patriknw @chbatey