Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove timebucket from clustering column, #399 #766

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Remove timebucket from clustering column, #399 #766

merged 2 commits into from
Apr 7, 2020

Conversation

patriknw
Copy link
Member

@patriknw patriknw commented Apr 6, 2020

  • originally there because of the materialized view
  • for old table definitions it must be set
  • would be difficult to remove it entirely from the table
    because then we would have to maintain two different insert statements
    depending on if the table defined the column or not, meaning that we
    would have to do some fake query when starting up to check if the column
    is defined

References #399

chbatey
chbatey approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@chbatey chbatey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, agreed not worth removing entirely. We have enough compat flags!

@chbatey
Copy link
Member

chbatey commented Apr 7, 2020

Looks like the event update needs updating:

[info] - must update the event in messages *** FAILED *** (218 milliseconds)
[info]   The future returned an exception of type: com.datastax.oss.driver.api.core.servererrors.InvalidQueryException, with message: Non PRIMARY KEY columns found in where clause: timebucket . (CassandraEventUpdateSpec.scala:67)
[info]   org.scalatest.exceptions.TestFailedException:
[info]   at org.scalatest.concurrent.Futures$FutureConcept.tryTryAgain$1(Futures.scala:531)
[info]   at org.scalatest.concurrent.Futures$FutureConcept.futureValueImpl(Futures.scala:550)
[info]   at org.scalatest.concurrent.Futures$FutureConcept.futureValueImpl$(Futures.scala:479)

@patriknw
Copy link
Member Author

patriknw commented Apr 7, 2020

fixed in df3d7ae

@patriknw
Remove timebucket from clustering column, #399
982c8e5 
* originally there because of the materialized view
* for old table definitions it must be set
* would be difficult to remove it entirely from the table
  because then we would have to maintain two different insert statements
  depending on if the table defined the column or not, meaning that we
  would have to do some fake query when starting up to check if the column
  is defined
@patriknw
fix CassandraEventUpdateSpec
3300af7
@patriknw
Copy link
Member Author

patriknw commented Apr 7, 2020

ReconnectSpec failed, trying again

@patriknw patriknw merged commit 7f2ad5d into master Apr 7, 2020
@patriknw patriknw deleted the wip-timebucket-patriknw branch April 7, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chbatey chbatey chbatey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patriknw @chbatey