chore: add extra logging for by-slice queries #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvlugter
force-pushed
the
query-extra-logging
branch
from
39b1679 to
04633cb
Compare
patriknw
reviewed
Dec 11, 2024
| Source | ||
| .fromPublisher(publisher) | ||
| .log(logName, logQueryResponse)(logging) |
There was a problem hiding this comment.
Could we propagate the logPrefix to the dao so that we try to have the same format, or at least similar prefix format here?
s"[$entityType] eventsBySlice [$slice]: "
Is there some added value of using stream log or shall we just add ordinary logging inside the mapConcat?
For example, stream fail will be logged at error level if we don't adjust the levels.
There was a problem hiding this comment.
I'll update the log prefix to be the same pattern. Yes, using the stream logging intentional here, so we can see the completions in particular. We could adjust failures to be debug as well, if we think error would be a problem.
patriknw
approved these changes
Dec 12, 2024
| // note that this is not logging each item, only the QueryResponse | ||
| .log(logName, logQueryResponse)(logging) | ||
| .withAttributes(Attributes | ||
| .logLevels(onElement = Logging.DebugLevel, onFinish = Logging.DebugLevel, onFailure = Logging.WarningLevel)) |
There was a problem hiding this comment.
setting the levels, warning instead of error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.