Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: metrics authentication & disable metrics, index, api docs #34

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

rwxd
Copy link
Contributor

@rwxd rwxd commented Feb 6, 2024

- added authentication to metrics endpoint
- config can deactivate authentication for metrics endpoint
- config can deactivate metrics endpoint
- config can deactivate index page
- config can deactivate customize index page
- config can deactivate api docs

- added authentication to metrics endpoint
- config can deactivate authentication for metrics endpoint
- config can deactivate metrics endpoint
- config can deactivate index page
- config can deactivate customize index page
- config can deactivate api docs
@rwxd rwxd requested a review from kuhball February 6, 2024 16:50
@rwxd
Copy link
Contributor Author

rwxd commented Feb 6, 2024

@kuhball schau dir bitte an, ob die Docs so Sinn machen, oder ob das vielleicht anders sortiert werden soll

@kuhball
Copy link
Contributor

kuhball commented Feb 7, 2024

Docs finde ich sauber und gut strukturiert.

Aktuell ist der Token für den metrics endpoint immer identisch zu dem Applikationstoken. Fände die Möglichkeit da unterschiedliche Tokens zu haben gar nicht so verkehrt. So ein bisschen aus dem Sichtpunkt ro / rw.

@rwxd
Copy link
Contributor Author

rwxd commented Feb 7, 2024

Das ist jetzt wie bei der Suche, solange zones eine leere Liste ist, kann der User nur suchen. Bei metrics_proxy: true dann nur Metriken anschauen.

    - name: pdnsgrep
      token_sha512: ""
      global_search: true
      zones: []
    - name: pdnsgrep
      token_sha512: ""
      metrics_proxy: true
      zones: []

@rwxd rwxd merged commit 8be0074 into main Feb 9, 2024
4 checks passed
@akqautomate
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants