Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics): analytics.service check whether ga function exists #5792

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

domudev
Copy link

@domudev domudev commented Oct 29, 2020

Please read and mark the following check list before creating a pull request (check one with "x"):

Short description of what this resolves:

This PR resolves issue #5523.

Once the analytics service is run it checks whether ga is actually defined (and a valid function). If that's not the case Google Analytics is disabled., therefore not throwing an error in the console.

The ga function can be blocked by an AdBlocker, leading to the prior bug.

@domudev domudev changed the title fix(analytics): analytics.service check whether ga function exists #5529 fix(analytics): analytics.service check whether ga function exists Oct 29, 2020
@domudev domudev closed this Oct 29, 2020
@domudev domudev reopened this Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant