Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routes implementation #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

romanyx
Copy link
Contributor

@romanyx romanyx commented May 3, 2018

#4

@romanyx romanyx mentioned this pull request May 3, 2018
@codecov-io
Copy link

Codecov Report

Merging #5 into master will decrease coverage by 10.81%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #5       +/-   ##
===========================================
- Coverage     100%   89.18%   -10.82%     
===========================================
  Files           1        1               
  Lines          26       37       +11     
===========================================
+ Hits           26       33        +7     
- Misses          0        4        +4
Impacted Files Coverage Δ
handler.go 89.18% <87.5%> (-10.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bca7a8c...76cc2de. Read the comment docs.

@al3rez
Copy link
Owner

al3rez commented May 5, 2018

it doesn't work with "{}/{id}": "{}/{id}/show" right? 'cause you're depending on routes.json as user defines the exact routes he/she wants to map a custom route to. am I right?

@romanyx
Copy link
Contributor Author

romanyx commented May 5, 2018

Yes, you're right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants