Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parent_lookup_kwargs raises an attribute error in django-spectacular api docs. #312

Conversation

73VW
Copy link

@73VW 73VW commented Aug 14, 2023

Fix for #311

@73VW 73VW changed the title parent_lookup_kwargs raises an attribute error in django-spectacular api docs. #311 parent_lookup_kwargs raises an attribute error in django-spectacular api docs. Aug 14, 2023
@dickermoshe
Copy link
Contributor

@alanjds
This check for a swagger request needs to be on the initialize_request too.
I've contributed PR #290 that added it to the get_queryset function.
It seems in needs to be added here as well.
It schema it generates is valid.
Can we get this merged into master

@alanjds
Copy link
Owner

alanjds commented Nov 7, 2023

@dickermoshe looks like your proposal was merged indirectly in meantime. I will close the PR as there is only string quotes changes now. Anyway, thanks for your contribution.

Best regards, Alan.

@alanjds alanjds closed this Nov 7, 2023
@73VW 73VW deleted the fix-parent-lookup-kwargs-error-with-spectacular branch November 8, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants