Separate documents by a unique sequence and make partition backwards scannable #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
t.b.d. - should the dataSize be added to the "footer", so that scanning backwards is more efficient? |
Add support for reading partition backwards
DeepCode's analysis on #e1f5f5 found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
albe
changed the title
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exchanges the
\n(newline) document separator with the sequence\x00\x00\x1E\n, which is distinguishing enough to be searchable in the partition. Hence, this will allow checking for unfinished writes and search the last valid document and even scan through the partition backwards.For optimization of that use case, the document data size is stored again before the document separator.
Resolves #124
Related to #31 #107