WIP: Miracast source side implementation #172

derekdai · 2017-02-15T10:52:52Z

Hi albfan:

What's in this PR

a unified interface to provide both source and sink functionality
source side RTSP protocol (partial implemented)
DBus control interface
a shell script to demo how to use miracle-wfdctl

If miraclecat is GO, miracle-dhcp runs as server, it send out SERVER_ID option in little endian, causes non-GO peer connect to wrong IP address, so RTSP connection can't be established. In scenario like, say Android (GO) <-> miracalcast (non-GO), the DHCP service is provided by Android, in this case, the SERVER_ID is in expected byte order (big endian).

since gstplayer has argument --audio to enable audio support but no way to disable it, audio=False might a better choise. If we left audio=True and incoming stream has video only, the whole pipeline will be blocked and wait for audio stream.

…null element

…o org.freedesktop.miracle

…valgrind

…inds of tunning

…ngle

The new option --lazy-managed will let miracle-wifid don't managed the links automatically. Instead, the link will be managed only when the new DBus property Managed was set to true. So this will be possible that miracle-wifid could be conexists with other network tools like networkmanager. For example, unmange the device in networkmanager with setting the DBus property org.freedesktop.NetworkManager.Device.Managed to false and manage it in miracle-wifid with setting org.freedesktop.miracle.wifi.Link.Managed to true, then both them could works and don't need to kill each other. Besides, there is new command named make-managed in miracle-wifictl and miracle-sinkctla.

…ation

…refix

while parsing ctl_peer and ctl_link objects, if a ctl_peer appear prior to its related ctl_link, -EINVAL is reported, and miracle-*ctl will quit immediately.

…lems to ease parsing

alexanderadam · 2018-01-24T09:21:25Z

wow, this looks impressive! @derekdai any chance that the mentioned points are getting fixed? It looks like you did an awesome amount of work!

albfan · 2018-09-22T07:06:10Z

@derekdai I just merge #135 so part of this PR can be rebased on top of that.

I will use your work on systemd services to fix #98, as using --lazy-managed allows to run it without any harm.

I decide to merge that PR trying again this one (founding that service running with --lazy-managed

I will rebase my branch https://github.com/albfan/miraclecast/tree/derekdai-master-squashed on top of master and try to split it into atomic changes.

Need to look again carefully as I feel lot more treasures are included in these PR

About this PR, My tries with external devices (were I don't control the miracast implementation) do not pass from the handshaking, but using my raspberry pi (now raspbian has systemd updated enough) I think I can get progress and see what is blocking these from being merged

ra100 · 2018-12-24T09:30:38Z

I tried to build (on ubuntu 18.04) these changes and got error while make:

miraclecast/res/dispctl.vala:807.2-807.18: error: 1 missing arguments for `void GLib.Application.set_default (GLib.Application?)'
	app.set_default();
	^^^^^^^^^^^^^^^^^
Compilation failed: 1 error(s), 2 warning(s)
res/CMakeFiles/miracle-dispctl.dir/build.make:80: recipe for target 'res/dispctl_valac.stamp' failed
make[2]: *** [res/dispctl_valac.stamp] Error 1
CMakeFiles/Makefile2:528: recipe for target 'res/CMakeFiles/miracle-dispctl.dir/all' failed
make[1]: *** [res/CMakeFiles/miracle-dispctl.dir/all] Error 2
Makefile:129: recipe for target 'all' failed
make: *** [all] Error 2

albfan · 2018-12-25T07:26:24Z

@ra100 there's a rebased branch derekdai-master-squashed with several fixes.

rfolland · 2019-04-23T06:19:35Z

Hi albfan,

What is the status of the WIP on source side Miraclecast? I have tried it and end up with an error when the app does not detect that connection is successful:

miracle-dispctl: failed to cast to wireless display: timeout to wait for property Connected change

Is there a setup which works, or is this the current status? Then I suppose some work is required to get the Connected status from dbus and move on?

albfan · 2019-04-23T09:27:01Z

It is not working for me too. We could check https://github.com/benzea/gnome-screencast and see what is different (not easy to do)

rfolland · 2019-04-23T11:00:26Z

It is not working for me too. We could check https://github.com/benzea/gnome-screencast and see what is different (not easy to do)

Thanks! I will try it out.

redbrain · 2020-11-30T15:49:35Z

Is this PR somewhat functional yet? I'd like to use Miraclecast as a source but it seems like progress is stalling.

albfan · 2022-11-01T20:17:46Z

This is still not working, but is rebased on top of master in https://github.com/albfan/miraclecast/tree/source-impl

Closing this PR to continue on #455

hypertextPreprocessor · 2024-08-21T18:42:37Z

sorry, I use this commit complie failed at make process. the error message shows

vala version : Vala 0.56.0
libglib version : libglib2.0-0
systemd version : 249 (249.11-0ubuntu3.12)
and I do checked valadoc ,it (the BusType) indeed has "get_address_sync" method , it has enum type though, see below:

Where was I wrong ? How can I complie this WIP?

derekdai and others added 30 commits February 13, 2017 13:12

set audio=False by default

9cd56f3

since gstplayer has argument --audio to enable audio support but no way to disable it, audio=False might a better choise. If we left audio=True and incoming stream has video only, the whole pipeline will be blocked and wait for audio stream.

init copy & modify

5f39158

calculate array size of resolutions at build time instead of tailing …

b6d372e

…null element

match resolution from high to low

c76667c

init source side implementation

5c501c0

add option [-f|--full-screen] to switch to full screen mode at start up

783fb7b

initial sender implementation

8a935e1

integrate miracle-sender with miracast-srcctl

0477753

stop sender when peer freed

fb37a53

source implement + sender talk via dbus

b3b5112

miracle-wifid: fix some leaks of wpas_message

21fc207

stability: increase gcc warning level

e1307f0

miracle-sender: change bus name from org.freedesktop.miracle.Sender t…

eb5c563

…o org.freedesktop.miracle

gstplayer: set sync=false to reduce latency

12cef6e

miracle-wifid: fix call waitid() with NULL pointer issue reported by …

91e1ee2

…valgrind

rename dbus name back to org.freedesktop.miracle.Sender and variety k…

03744ba

…inds of tunning

encode video with x264enc temperarily to prevent decoding issue on do…

d8d538e

…ngle

stop sender properly after session end

20ff174

miracle-srcctl: fix memory management issues

d239c52

miracle-wifid: add dbus & systemd service files to support dbus activ…

c5a4bf0

…ation

miracle-wifid: remove duplicated link & peer dbus nodes by checking p…

853152c

…refix

miracle-srcctl: fix some warming

1919de3

miracle-wifid: add MACAddress property to link

df336c8

miracle-wfdctl: init commit

f47669a

miracle-*ctl: remove some debugging log messages

cfc9809

miracle-*ctl: resolve object parsing issue in ctl_wifi_fetch()

14041bd

while parsing ctl_peer and ctl_link objects, if a ctl_peer appear prior to its related ctl_link, -EINVAL is reported, and miracle-*ctl will quit immediately.

miracle-*ctl: fix label leak

7ea9305

miracle-wifid: let the format of wfd_dev_info compliant with wfd_sube…

8381290

…lems to ease parsing

albfan mentioned this pull request Jul 15, 2017

Mirroring to Hisense #217

Closed

albfan mentioned this pull request Nov 10, 2017

Connecting to Wireless Projector #244

Closed

albfan mentioned this pull request Jan 1, 2018

Running old version of miraclecast on Ubuntu 17.10 #251

Closed

albfan mentioned this pull request Jan 23, 2018

Using MiracleCast as source in RPI 3 #257

Closed

bernd-wechner mentioned this pull request Jul 13, 2018

miraclecast as source #4

Open

albfan force-pushed the master branch from 0c59cc7 to 4e67272 Compare September 22, 2018 06:53

albfan mentioned this pull request Sep 22, 2018

Make miracle-wifid conexists with other network tools #135

Closed

albfan mentioned this pull request Oct 2, 2018

miraclecast as source - cannot connect to the android TV box sink #297

Closed

albfan mentioned this pull request Oct 23, 2018

Installing WIP miraclecast as source in Ubuntu 16.04 #301

Closed

This was referenced Nov 4, 2018

ERROR: cannot retrieve objects: The name org.freedesktop.miracle.wifi was not provided by any .service files (ctl_wifi_fetch() in ....../miraclecast/src/ctl/ctl-wifi.c:1172) #298

Closed

ignored device: wlan0 (Qualcomm Atheros - QCA9377) #303

Closed

edurenye mentioned this pull request Nov 7, 2018

Source side implementation #304

Closed

albfan mentioned this pull request Nov 29, 2018

hardware capability test fails #312

Closed

albfan force-pushed the master branch from 986f596 to df12df6 Compare October 27, 2021 10:11

Repository owner deleted a comment from piranna Feb 14, 2022

Repository owner deleted a comment from fsevenm Feb 14, 2022

albfan closed this Nov 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Miracast source side implementation #172

WIP: Miracast source side implementation #172

derekdai commented Feb 15, 2017

alexanderadam commented Jan 24, 2018

albfan commented Sep 22, 2018

ra100 commented Dec 24, 2018 •

edited

Loading

albfan commented Dec 25, 2018 •

edited

Loading

rfolland commented Apr 23, 2019

albfan commented Apr 23, 2019

rfolland commented Apr 23, 2019

redbrain commented Nov 30, 2020

albfan commented Nov 1, 2022

hypertextPreprocessor commented Aug 21, 2024

WIP: Miracast source side implementation #172

WIP: Miracast source side implementation #172

Conversation

derekdai commented Feb 15, 2017

alexanderadam commented Jan 24, 2018

albfan commented Sep 22, 2018

ra100 commented Dec 24, 2018 • edited Loading

albfan commented Dec 25, 2018 • edited Loading

rfolland commented Apr 23, 2019

albfan commented Apr 23, 2019

rfolland commented Apr 23, 2019

redbrain commented Nov 30, 2020

albfan commented Nov 1, 2022

hypertextPreprocessor commented Aug 21, 2024

ra100 commented Dec 24, 2018 •

edited

Loading

albfan commented Dec 25, 2018 •

edited

Loading