Prefer int math when constructing DateTime from milliseconds #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Unix Timestamp with microseconds" notation was introduced in php/php-src@5562654 and originally expected exactly six points of precision. The format was relaxed in php/php-src@0bc8785 for PHP 8.0+ to accept between zero and six points of precision.
alcaeus
force-pushed
the
phpc-2429-fix-utcdatetime
branch
3 times, most recently
from
1f4065c
to
3974587
Compare
|
Closing, as this was already sorted out in mongodb#1623. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Unix Timestamp with microseconds" notation was introduced in php/php-src@5562654 and originally expected exactly six points of precision. The format was relaxed in php/php-src@0bc8785 for PHP 8.0+ to accept between zero and six points of precision.