Antonyjin upgrade pydantic version #293
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aleph-message and sdk now uses pydantic v2 but no released yet Using the github link atm and wait for the release.
When upgrading the pydantic version, some function are / will become deprecated. replacing them in those files.
Added `default=extended_json_encoder` to `json.dumps()` to handle serialization of non-native JSON types, such as dates and other complex objects. Replacing function that are / will be deprecated in pydantic v2 and v3
|
Failed to retrieve llama text: POST 504: 504 Gateway Time-outThe server didn't respond in time. |
Pydantic>=2 is not compatible with fastapi<0.100.0
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #293 +/- ##
=======================================
Coverage 39.82% 39.83%
=======================================
Files 18 18
Lines 2117 2119 +2
Branches 257 257
=======================================
+ Hits 843 844 +1
- Misses 1222 1223 +1
Partials 52 52 ☔ View full report in Codecov by Sentry. |
Conflit between pydantic and yamlfix black did not pass
With Pydantic v2, strict type validation is enforced. The type field is expected to have the exact value "POST" as a literal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue aims to upgrade the pydantic version to v2.
Related Jira tickets : ALEPH-149
Self proofreading checklist
Changes
Many functions will be deprecated using pydantic v2 and completly unusable when using pydantic v3. So all of them have been replaced with the good ones.
How to test
hatch run testing-test-cov
Notes
At the moment, aleph-message and aleph-sdk-python version use the github link. We need to wait the release of these two repositories and then put the right version instead of the github URL