-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AlephClientBase and AuthenticatedAlephClientBase #54
Conversation
Thanks for this proposal for improving the SDK. The capability of using generators such as your suggestion for I believe that there is a better way of doing this than adding such method, and I experimented a bit with a new Pull Request here: #58 |
66f456f
to
ec518b5
Compare
Merging the PRs that are lined up would conflict with the proposed changes in #58. I would offer to take these suggested changes and make another PR that integrates better with the new ABCs and MessageCache/DomainNode classes. |
… alternative client implementations
4e4a576
to
93d1e2e
Compare
@hoh and me agreed to continue with merging the branch after another review. I will take care of implementing certain features of #58 in future PRs on the basis of this PR and #59, but will now prioritize UX, especially around deployment and managing of VMs, as new features will hit https://github.com/aleph-im/aleph-vm soon. @odesenfans please review the requested changes and approve, if no further required. |
Adding abstract base classes for the client classes and add several improvements:
get_messages_iterator
orget_posts_iterator
.get_posts
now returns aPostsResponse
type instead of untyped dictionaryget_messages
andwatch_messages
as both should have the same query parameters