Feature: authenticated file upload SDK #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoh
reviewed
Aug 28, 2023
odesenfans
force-pushed
the
1yam_secure_file_upload
branch
from
9d1536d
to
d27fad1
Compare
Problem: `pip install .[testing]` is not enough to run all tests successfully. Solution: add missing packages to the "testing" install target.
MHHukiewitz
previously approved these changes
Oct 10, 2023
… methods; Client classes are bloated and have unused parameters Solution: add MessageFilter & PostFilter; remove limit parameter;
…; aggregate fetching could result in unhandled parsing errors Solution: Adjust integration tests for current functionality; add raise_for_status to GET aggregates requests
…es and their contained functions did not correspond to another Solution: refactor client.py into own module; rename pagination to page_size where possible; refactor models module
…slow down performance Solution: Prevent unnecessary .as_http_params() calls
…els module is too broad of a name; client module classes had unclear naming Solution: Restructure and remove the sync wrapper; Move models' functions into new query module and existing files; Rename client classes
Solution: Debug examples and only use async client
Fix: exemple multiple fixes fix tests
…ython into 1yam_secure_file_upload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK implementations of : aleph-im/pyaleph#463