Refactor AlephClient classes #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoh
reviewed
Oct 6, 2023
|
I refactored the package structure quite substantially here now, so not only we do now have a |
hoh
force-pushed
the
mhh-base-client-0.8.0-alpha.1
branch
2 times, most recently
from
47c32d0
to
2e9878f
Compare
|
The diff looks good 👍 . Can you rebase the commits to have clear atomic changes that follow our git commit style ? |
… methods; Client classes are bloated and have unused parameters Solution: add MessageFilter & PostFilter; remove limit parameter;
…; aggregate fetching could result in unhandled parsing errors Solution: Adjust integration tests for current functionality; add raise_for_status to GET aggregates requests
…es and their contained functions did not correspond to another Solution: refactor client.py into own module; rename pagination to page_size where possible; refactor models module
…slow down performance Solution: Prevent unnecessary .as_http_params() calls
…els module is too broad of a name; client module classes had unclear naming Solution: Restructure and remove the sync wrapper; Move models' functions into new query module and existing files; Rename client classes
Solution: Debug examples and only use async client
MHHukiewitz
force-pushed
the
mhh-base-client-0.8.0-alpha.1
branch
from
18b4921
to
df26946
Compare
hoh
changed the title
hoh
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in preparation for the alpha release of v0.8.0 and contains all changes to the client's interface that are intended for the breaking release v0.8.0.
MessageFilterandPostFilter, inspired by Refactor: Filters were messy with duplication #58limitparameter infetch_aggregate()andfetch_aggregates